Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file-scoped namespaces #7

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

nguerrera
Copy link
Contributor

Save some indentation. Better to touch every line sooner than later. 😊

Reviewing individual commits may be helpful.

  1. dotnet format with current .editorconfig
  2. update .editorconfig to use file-scoped namespaces, dotnet format again.
  3. delete commented out file because it confused me that count of .cs files touched didn't match expectation.

@nguerrera
Copy link
Contributor Author

Hide whitespace option also helpful for review.

@@ -5,63 +5,62 @@

using System.Security.Cryptography;

namespace CommonAnnotatedSecurityKeys.Benchmarks
namespace CommonAnnotatedSecurityKeys.Benchmarks;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace

If it were done when 'tis done, then 'twere well it were done quickly

Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nguerrera nguerrera merged commit 58020ed into microsoft:main Nov 26, 2024
4 checks passed
@nguerrera nguerrera deleted the file-scope-ns branch November 26, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants